-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add i18n-context-service to inject custom contexts #383
base: main
Are you sure you want to change the base?
feat: Add i18n-context-service to inject custom contexts #383
Conversation
@toonvanstrijp Have you had any time to look at this yet? |
@jurienhamaker I'll take a look at it right now ;) |
@jurienhamaker looks good so far, the only thing that I'm not sure about yet is how to make the |
@jurienhamaker @jurienhamaker alright I have a potential solution. In the |
@toonvanstrijp Any updates? |
@toonvanstrijp can you look on this one on your free time. Since this is older and almost mergeable I would like your input. This will help close few issue |
Hey @toonvanstrijp, can you check this pull request please!? 🙏 |
Or you @rubiin? |
plz fix the merge conflicts |
can you fix the conflicts and accept the changes to update the version? or can I do this in your pr? |
@BARTlab go ahead |
@jurienhamaker you're welcome! |
Currently I am working on a project that has a custom request scope.
Similair how this package provides rpc, graphql & http out of the box. This will allow the user to add custom contexts and functions to get the context of said custom context.
I do need some help with the
I18nLang
decorator, since I have no clue how I could inject the service into aparamDecorator
.Same for the tests, any suggestions are welcome.