Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Remove constraints on gems and Travis CI #15

Merged
merged 3 commits into from
Feb 2, 2022
Merged

feat!: Remove constraints on gems and Travis CI #15

merged 3 commits into from
Feb 2, 2022

Conversation

jdehaan
Copy link
Collaborator

@jdehaan jdehaan commented Feb 2, 2022 •
edited
Loading

Goals

  • Extend the support of this plugin to other redmine setups
  • Remove obsolete stuff

@jdehaan jdehaan self-assigned this Feb 2, 2022
@jdehaan jdehaan changed the title feat!: Remove constraints on gems and update CI feat!: Remove constraints on gems and Travis CI Feb 2, 2022
@jdehaan jdehaan requested review from swiehr and udl February 2, 2022 12:31
@jdehaan
Copy link
Collaborator Author

jdehaan commented Feb 2, 2022

Normally other packages should ensure the versions finally selected are ok.

jdehaan
jdehaan commented Feb 2, 2022
View reviewed changes
.rubocop.yml
@@ -4,7 +4,7 @@ require:
- rubocop-rake
- rubocop-rspec
AllCops:
TargetRubyVersion: 2.4
TargetRubyVersion: 2.5
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set to 2.5 because we still maybe want to remain compatible to 2.5 at least for a while

udl
udl approved these changes Feb 2, 2022
View reviewed changes
Copy link
Collaborator

@udl udl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

As you said, downstream projects can specify a lower version for rubocop if needed.

@jdehaan jdehaan merged commit 74b5739 into master Feb 2, 2022
@jdehaan jdehaan deleted the fix/unconstrain-rubocop branch February 2, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@udl udl udl approved these changes

@swiehr swiehr Awaiting requested review from swiehr

Assignees

@jdehaan jdehaan

Labels
Review needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdehaan @udl