Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ACE editor support #84

Closed
wants to merge 1 commit into from
Closed

Conversation

Zhigalin
Copy link

No description provided.

@tonsky
Copy link
Owner

tonsky commented Dec 20, 2015

Well, ACE isn’t a standalone editor, is it? So it should be covered by “Browsers support” section already?

@Zhigalin
Copy link
Author

Well, a in-browser code editor is a bit more complex than a simple textarea...
Actually I don't know how it could work because every character is placed inside a separate div... But it works.

@MadcapJake
Copy link

Isn't Atom based on Ace? If so, it actually groups characters by span via a grammar tokenizer. So if the language grammar groups two chars together, it will come up ligaturized in Fira Code. A cursory inspection of github seems to support this (though each row is actually a <tr>).

@tonsky tonsky closed this in e2181ad Dec 21, 2015
@tonsky
Copy link
Owner

tonsky commented Dec 21, 2015

Ok, I added ACE and CodeMirror to the browsers section

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants