Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fl/fi ligatures #795

Closed
sahil48 opened this issue Jul 17, 2019 · 8 comments
Closed

Add fl/fi ligatures #795

sahil48 opened this issue Jul 17, 2019 · 8 comments
Labels
suggestion
Milestone
2

Comments

@sahil48
Copy link

sahil48 commented Jul 17, 2019

Right now it feels that there is too little spacing between the f and l characters when they are next to each other. I feel that the font would look better if they would be replaced with an fl ligature, or the top half-serif on the l could be shortened.

image
@sahil48 sahil48 changed the title Improve "fl" character set Suggestions: Improve "fl" character set Jul 17, 2019
@tonsky tonsky added this to the 1.208 milestone Aug 27, 2019
@tonsky tonsky changed the title Suggestions: Improve "fl" character set Add fl/fi ligatures Aug 27, 2019
@tonsky tonsky closed this as completed in 1c2a034 Sep 2, 2019
tonsky added a commit that referenced this issue Sep 9, 2019
@tonsky
fi, fj, fl, Fl, Tl ligatures (#795)
6a9cfb8
tonsky added a commit that referenced this issue Sep 9, 2019
@tonsky
made fi/fj not ligatures, adjusted top serif of i/j instead #795
f3d6a36
@bytemain
Copy link

image
It made me very uncomfortable...
feel bad.

@awmottaz
Copy link

I agree, not a big fan of how this turned out

@sahil48
Copy link
Author

sahil48 commented Sep 17, 2019 •
edited
Loading

Referring to the initial example, perhaps instead, the fl ligature could be created where there is more separation between the top stem/serif of the "f" and "l" rather than fusing them together.

@efficientbug efficientbug mentioned this issue Oct 9, 2019
Open
@Avi-D-coder
Copy link

Fira Mono does not have these ligatures, if we must have them can they at least be consistent with Fira sans?

Currently they are jarring. Where as I hardly notice Fira sans fl and fj ligatures.

Avi-D-coder added a commit to Avi-D-coder/FiraCode that referenced this issue Oct 18, 2019
@Avi-D-coder
Revert "made fi/fj not ligatures, adjusted top serif of i/j instead t…
91654b2 
…onsky#795"

This reverts commit f3d6a36.
Avi-D-coder added a commit to Avi-D-coder/FiraCode that referenced this issue Oct 18, 2019
@Avi-D-coder
Revert "fi, fj, fl, Fl, Tl ligatures (tonsky#795)"
f9c0992 
This reverts commit 6a9cfb8.
@adah1972
Copy link

I agree with many commenters that these ligatures look pretty bad. I would advocate these changes should be reverted.

I do not think such ligatures should be enabled in a monospace font.

@Avi-D-coder
Copy link

I removed these ligatures and built otf

@adah1972
Copy link

@Avi-D-coder Thanks. Did you make a pull request to this master project?

@Arcitec
Copy link

Arcitec commented Nov 25, 2019 •
edited
Loading

@tonsky Hi Nikita. Have you seen the discussion here? Many people (including me) strongly dislike these ligatures. They look jarring in a monospace font (everything is spaced out, but then suddenly f and l are fused!?). And worst of all, Tl with the new ligatures looks like π (pi). Wtf. Hehe. Please make these ligatures optional via ss setting... :-( The first feeling after installing the font today was "wow this font is beautiful, but... ewwww that ligature... can I turn it off somehow?"... Sad that I can't. :-( I'd much prefer the original in the OP's post above. :-S

Edit: Ehm... my love for Fira Code was short lived (about 15 minutes). The "Fl / Tl" was so painful to look at that I started looking for other fonts. Found IBM Plex Mono at https://www.ibm.com/plex/ (https://github.com/IBM/plex/releases) which was designed by IBM for their programmers, to be looked at day in and day out. They used pixel-precise angles to ensure sharp rendering. It is incredibly crisp, extremely easy to read, and expertly designed. The italics are a work of art (which my editor uses for comments) and are based on the famous 1960s IBM Selectric Typewriter, which gives it a very cool and unique design. There are no ligatures for stuff like !=, but the font puts those characters super close to each other (which looks great), so I don't miss ligatures. There is a modded version at IBM/plex#63 (comment) which adds ligatures if someone really wants that in the IBM Plex font... :-) Anyway, if Fira Code improves the "Pi"-like "Tl" situation, I will revisit this font too, because it's a nice font... but I'm off to IBM land for now...

@tonsky tonsky mentioned this issue Nov 25, 2019
Closed
Losangelosgenetics pushed a commit to Losangelosgenetics/FiraCode that referenced this issue Mar 13, 2020
@antstorm
Mention locale_backend in the README (tonsky#795)
a51304a
jeremyschlatter added a commit to jeremyschlatter/env that referenced this issue Sep 22, 2020
@jeremyschlatter
bump fira-code to unstable
c0f9ea9 
The stable version of fira-code has these [weird][1] and [unpopular][2]
ligatures for "fl" and "Fl". They are jarring, especially now that I'm
rendering the word "flake" a lot.

Fortunately, they've been reverted upstream. Bumping fira-code to
unstable until the fix lands back on stable.

[1]: tonsky/FiraCode#795
[2]: tonsky/FiraCode#902
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
suggestion
Projects
None yet
Milestone
2
Development

No branches or pull requests
7 participants
@tonsky @adah1972 @sahil48 @bytemain @awmottaz @Avi-D-coder @Arcitec