Merge pull request moby#3424 from benlongo/use-skip-output-instead-of…

…-negative-indexes Use SkipOutput instead of -1 for output indexes to clarify semantics.
tonistiigi · Dec 20, 2022 · c0e38e1 · c0e38e1
2 parents f5551cc + 97a45ef
commit c0e38e1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/client/llb/exec.go b/client/llb/exec.go
@@ -339,7 +339,7 @@ func (e *ExecOp) Marshal(ctx context.Context, c *Constraints) (digest.Digest, []
 			inputIndex = pb.Empty
 		}
 
-		outputIndex := pb.OutputIndex(-1)
+		outputIndex := pb.SkipOutput
 		if !m.noOutput && !m.readonly && m.cacheID == "" && !m.tmpfs {
 			outputIndex = pb.OutputIndex(outIndex)
 			outIndex++

diff --git a/client/llb/fileop.go b/client/llb/fileop.go
@@ -702,7 +702,7 @@ func (f *FileOp) Marshal(ctx context.Context, c *Constraints) (digest.Digest, []
 	pop.Inputs = state.inputs
 
 	for i, st := range state.actions {
-		output := pb.OutputIndex(-1)
+		output := pb.SkipOutput
 		if i+1 == len(state.actions) {
 			output = 0
 		}