Avoid executable path resolution in buildkit-qemu-* #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The buildkit inline emulator resolves paths of the binary it executes. This is needed for readlink()/open()/... to work on /proc/self/exe correctly, in case the binary changes its working directory. However the resolution may result in unexpected args values. So avoid passing the resolved paths around, but use them when the emulated process accesses /proc/self/exe. Known issue - a shell script like `#!./chwd` will still not work as expected, as it will set /proc/self/exe to the script, rather than the actual executable. Signed-off-by: Piotr Stankiewicz <[email protected]>
p1-0tr
force-pushed
the
ps-fix-exe-resolution
branch
from
dca9ebe to
b727548
Compare
p1-0tr
changed the title
crazy-max
approved these changes
Feb 4, 2025
tonistiigi
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The buildkit inline emulator resolves paths of the binary it executes.
This is needed for readlink()/open()/... to work on /proc/self/exe
correctly, in case the binary changes its working directory. However the
resolution may result in unexpected args values. So avoid passing the
resolved paths around, but use them when the emulated process accesses
/proc/self/exe.
Known issue - a shell script like
#!./chwdwill still not work as expected,as it will set /proc/self/exe to the script, rather than the actual
executable.