Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump qemu to v9.2.0 #216

Merged
merged 4 commits into from
Jan 29, 2025
Merged

Conversation

p1-0tr
Copy link
Collaborator

@p1-0tr p1-0tr commented Jan 23, 2025

Follow up on #205

Let's see if the build failures on #205 persist with qemu v9.2.0. I did not manage to get a local repro for now.

@p1-0tr p1-0tr force-pushed the ps-bump-qemu-v9.2.0 branch from 8aecece to 32510ad Compare January 23, 2025 12:26
@crazy-max
Copy link
Collaborator

crazy-max commented Jan 23, 2025

This e2e test failure does not seem qemu related, might need to fix this test with webpack: https://github.com/tonistiigi/binfmt/actions/runs/12929139787/job/36058578240?pr=216#step:6:113

 #13 [8/8] RUN webpack    --verbose    --display=verbose    --info-verbosity=verbose    --display-exclude    --display-modules    --display-max-modules    --display-chunks    --display-entrypoints    --display-origins    --display-cached    --display-cached-assets    --display-reasons    --display-depth    --display-used-exports    --display-provided-exports    --display-optimization-bailout    --display-error-details
#13 1.217 /usr/local/lib/node_modules/webpack-cli/node_modules/commander/lib/command.js:396
#13 1.217     enableOrNameAndArgs = enableOrNameAndArgs ?? 'help [command]';
#13 1.217                                                ^
#13 1.217 
#13 1.217 SyntaxError: Unexpected token '?'
#13 1.217     at wrapSafe (internal/modules/cjs/loader.js:915:16)
#13 1.217     at Module._compile (internal/modules/cjs/loader.js:963:27)
#13 1.217     at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
#13 1.217     at Module.load (internal/modules/cjs/loader.js:863:32)
#13 1.217     at Function.Module._load (internal/modules/cjs/loader.js:708:14)
#13 1.217     at Module.require (internal/modules/cjs/loader.js:887:19)
#13 1.217     at require (internal/modules/cjs/helpers.js:74:18)
#13 1.217     at Object.<anonymous> (/usr/local/lib/node_modules/webpack-cli/node_modules/commander/index.js:2:21)
#13 1.217     at Module._compile (internal/modules/cjs/loader.js:999:30)
#13 1.217     at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)

@p1-0tr
Copy link
Collaborator Author

p1-0tr commented Jan 23, 2025

This e2e test failure does not seem qemu related, might need to fix this test with webpack: https://github.com/tonistiigi/binfmt/actions/runs/12929139787/job/36058578240?pr=216#step:6:113

 #13 [8/8] RUN webpack    --verbose    --display=verbose    --info-verbosity=verbose    --display-exclude    --display-modules    --display-max-modules    --display-chunks    --display-entrypoints    --display-origins    --display-cached    --display-cached-assets    --display-reasons    --display-depth    --display-used-exports    --display-provided-exports    --display-optimization-bailout    --display-error-details
#13 1.217 /usr/local/lib/node_modules/webpack-cli/node_modules/commander/lib/command.js:396
#13 1.217     enableOrNameAndArgs = enableOrNameAndArgs ?? 'help [command]';
#13 1.217                                                ^
#13 1.217 
#13 1.217 SyntaxError: Unexpected token '?'
#13 1.217     at wrapSafe (internal/modules/cjs/loader.js:915:16)
#13 1.217     at Module._compile (internal/modules/cjs/loader.js:963:27)
#13 1.217     at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
#13 1.217     at Module.load (internal/modules/cjs/loader.js:863:32)
#13 1.217     at Function.Module._load (internal/modules/cjs/loader.js:708:14)
#13 1.217     at Module.require (internal/modules/cjs/loader.js:887:19)
#13 1.217     at require (internal/modules/cjs/helpers.js:74:18)
#13 1.217     at Object.<anonymous> (/usr/local/lib/node_modules/webpack-cli/node_modules/commander/index.js:2:21)
#13 1.217     at Module._compile (internal/modules/cjs/loader.js:999:30)
#13 1.217     at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)

Yup, a quick google search seems to suggest the issue can happen if the node version is out of whack. Looking into why this may be happening.

@crazy-max crazy-max force-pushed the ps-bump-qemu-v9.2.0 branch from b009c88 to fd20a4e Compare January 23, 2025 14:16
crazy-max
crazy-max previously approved these changes Jan 23, 2025
Copy link
Collaborator

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crazy-max
Copy link
Collaborator

Ah actually it fails to build targets: https://github.com/tonistiigi/binfmt/actions/runs/12931102484/job/36065715925?pr=216#step:7:1907

 #45 [linux/amd64->386 build 1/2] RUN --mount=target=.,from=src,src=/src/qemu,rw --mount=target=./install-scripts,src=scripts   TARGETPLATFORM=linux/386 configure_qemu.sh &&   make -j "$(getconf _NPROCESSORS_ONLN)" &&   make install &&   cd /usr/bin && for f in $(ls qemu-*); do xx-verify --static $f; done
#45 0.380 + xx-info
#45 0.388 + xx-clang --print-target-triple
#45 0.400 + xx-clang --print-target-triple
#45 0.412 + TARGETPLATFORM= TARGETPAIR= xx-clang --print-target-triple
#45 0.452 + xx-clang --print-target-triple
#45 0.464 + ./configure '--prefix=/usr' '--with-pkgversion=v9.2.0' --enable-linux-user --disable-system --static --disable-brlapi --disable-cap-ng --disable-capstone --disable-curl --disable-curses --disable-docs --disable-gcrypt --disable-gnutls --disable-gtk --disable-guest-agent --disable-guest-agent-msi --disable-libiscsi --disable-libnfs --disable-mpath --disable-nettle --disable-opengl --disable-pie --disable-sdl --disable-spice --disable-tools --disable-vte --disable-werror --disable-debug-info --disable-glusterfs '--cross-prefix=i586-alpine-linux-musl-' '--host-cc=i586-alpine-linux-musl-clang' '--host=i586-alpine-linux-musl' '--build=x86_64-alpine-linux-musl' '--cc=i586-alpine-linux-musl-clang' '--extra-ldflags=-latomic' '--target-list= x86_64-linux-user aarch64-linux-user arm-linux-user riscv64-linux-user ppc64le-linux-user s390x-linux-user mips64el-linux-user mips64-linux-user loongarch64-linux-user'
#45 0.466 Using './build' as the directory for build output
#45 0.815 python determined to be '/usr/bin/python3'
#45 0.818 python version: Python 3.12.8
#45 0.925 mkvenv: Creating non-isolated virtual environment at 'pyvenv'
#45 5.859 mkvenv: checking for meson>=1.5.0
#45 5.861 mkvenv: checking for pycotap>=1.1.0
#45 5.862 mkvenv: installing meson==1.5.0, pycotap==1.3.1
#45 9.666 The Meson build system
#45 9.666 Version: 1.5.0
#45 9.666 Source dir: /qemu
#45 9.666 Build dir: /qemu/build
#45 9.666 Build type: cross build
#45 9.666 Project name: qemu
#45 9.666 Project version: 9.2.0
#45 9.666 
#45 9.666 ../meson.build:1:0: ERROR: Could not invoke sanity test executable: [Errno 2] No such file or directory: '/qemu/build/meson-private/sanitycheckc_cross.exe'.
#45 9.666 
#45 9.666 A full log can be found at /qemu/build/meson-logs/meson-log.txt
#45 9.761 
#45 9.761 ERROR: meson setup failed
#45 9.761 

Seems cross build related, I will try another repro

doringeman and others added 4 commits January 29, 2025 18:37
Signed-off-by: Dorin Geman <[email protected]>
Signed-off-by: Piotr Stankiewicz <[email protected]>
Signed-off-by: Piotr Stankiewicz <[email protected]>
@crazy-max crazy-max force-pushed the ps-bump-qemu-v9.2.0 branch from 2eb1f0d to 94bc718 Compare January 29, 2025 17:38
@crazy-max crazy-max merged commit 14ebeca into tonistiigi:master Jan 29, 2025
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants