Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phoenix minor mode is not working for Phoenix >= 1.3 #306

Open
Spadavecchia opened this issue Jun 22, 2017 · 7 comments
Open

Phoenix minor mode is not working for Phoenix >= 1.3 #306

Spadavecchia opened this issue Jun 22, 2017 · 7 comments
Labels
help wanted Kind:Bug

Comments

@Spadavecchia
Copy link

Spadavecchia commented Jun 22, 2017 •
edited
Loading

Phoenix >= 1.3 changes the structure of the project, including files and directories. So Alchemist is not recognizing a Phoenix >= 1.3 project and the minor mode is not working anymore.
@tonini
Copy link
Owner

tonini commented Jun 22, 2017

Thanks a lot for this report, I'll try to fix this asap.

@jonathan-soifer
Copy link
Contributor

I'm getting the Could not find a Phoenix Project root error. I'm assuming this is the same thing you're referring to @Spadavecchia ?

gebrek added a commit to gebrek/alchemist.el that referenced this issue Sep 11, 2017
@gebrek
Fix alchemist-phoenix for new phoenix structure (tonini#306)
40a6bcb 
The `web' directory is removed with phx1.3 and placed under
lib/<app-name>_web instead.

Also change phoenix.routes -> phx.routes
@gebrek
Copy link

gebrek commented Sep 11, 2017

I worked on this. It fails alchemist-phoenix-test/a-phoenix-project though, since that test doesn't match the directory structure of phoenix anymore with 'web' in the project root.

@simpers
Copy link

simpers commented Apr 9, 2018

What's the progress on this?

dsdshcym pushed a commit to dsdshcym/alchemist.el that referenced this issue May 24, 2018
@gebrek @dsdshcym
Fix alchemist-phoenix for new phoenix structure (tonini#306)
9b9f37d 
The `web' directory is removed with phx1.3 and placed under
lib/<app-name>_web instead.

Also change phoenix.routes -> phx.routes
@mnuessler
Copy link

Still no update?

@arubis
Copy link

arubis commented Jan 27, 2019

Gentle suggestion: change issue title to reference "Phoenix >= 1.3" so this doesn't get lost going forward.

@aislanmaia
Copy link

Would be nice to have this improvement in place.

baron pushed a commit to baron/alchemist.el that referenced this issue Mar 19, 2019
@gebrek @baron
Fix alchemist-phoenix for new phoenix structure (tonini#306)
4f8a291 
The `web' directory is removed with phx1.3 and placed under
lib/<app-name>_web instead.

Also change phoenix.routes -> phx.routes
@Spadavecchia Spadavecchia changed the title Phoenix minor mode is not working for Phoenix 1.3 Phoenix minor mode is not working for Phoenix >= 1.3 Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Kind:Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@arubis @tonini @mnuessler @Spadavecchia @aislanmaia @simpers @gebrek @jonathan-soifer