Dynamic Tags - Reduce and cache replacement requests #1619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iansvo
added
feature
tomusborne
reviewed
Dec 30, 2024
tomusborne
reviewed
Dec 30, 2024
tomusborne
reviewed
Dec 30, 2024
tomusborne
reviewed
Dec 31, 2024
| tagName, | ||
| isSavingPost, | ||
| blockCacheKey, | ||
| isSelected, |
There was a problem hiding this comment.
Do we want/need this to run every time isSelected changes?
There was a problem hiding this comment.
I can test again to make 100% sure, but I feel like this was necessary to refresh the value in case it changed or something along those lines. I've done a few PRs since then so I don't remember offhand.
tomusborne
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to: #1616
This PR implements a local client side cache and server side object cache to reduce the amount of requests and database lookups. Based on my tests it seems to be much faster afterwards. Please have a look and let me know what you see.