Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BG Placeholder handling #1532

Merged
merged 4 commits into from
Nov 27, 2024
Merged

BG Placeholder handling #1532

merged 4 commits into from
Nov 27, 2024

Conversation

iansvo
Copy link
Collaborator

@iansvo iansvo commented Nov 25, 2024 •
edited
Loading

tomusborne
tomusborne requested changes Nov 25, 2024
View reviewed changes
Copy link
Owner

@tomusborne tomusborne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use generateBlocksEditor instead.

@iansvo iansvo requested a review from tomusborne November 26, 2024 13:09
@iansvo
Copy link
Collaborator Author

iansvo commented Nov 26, 2024

Update this to use the editor global

@tomusborne tomusborne merged commit a408c4f into release/2.0.0 Nov 27, 2024
9 checks passed
@tomusborne tomusborne deleted the bug/placeholder-bg-image branch November 27, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomusborne tomusborne Awaiting requested review from tomusborne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iansvo @tomusborne