Convert tests to unittest #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 30, 2022
Open
tomsilver
approved these changes
Dec 30, 2022
| From the root of the repo, run | ||
|
|
||
| ```sh | ||
| python -m unittest discover pddlgym/tests/ |
There was a problem hiding this comment.
confirmed that this works as expected 👍
pddlgym/tests/test_inference.py
Outdated
| test_negative_preconditions() | ||
| test_zero_arity_negative_preconditions() | ||
|
|
||
| unittest.main() |
|
|
||
|
|
||
| class TestSearchAndRescue(unittest.TestCase): | ||
| def skip_test_searchandrescue(self, num_actions_to_test=10, verbose=False): |
There was a problem hiding this comment.
why is this skipped? oh, I guess we were skipping it already. fair enough!
There was a problem hiding this comment.
Yup! The calling line was previously commented out. I figured you wanted the code present, but unused, and making this NOT start with test_ makes unittest skip it by default.
pddlgym/tests/test_system.py
Outdated
|
|
||
|
|
||
| if __name__ == '__main__': | ||
| test_system() | ||
| unittest.main() |
aymeric75
pushed a commit
to aymeric75/pddlgym
that referenced
this pull request
May 22, 2024
Convert tests to unittest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out from #67 .