-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable resize of weekday event slot #222
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went ahead and removed a wrapping div which looked redundant to me. Feel free to revert though if I missed out on something.
E2E tests are failing though, and I'm not quite sure why yet.
It appears to me, that this fixes an old problem I didn't know Qalendar had - namely text overflow from week events. At least sometimes when they're very short. That seems to be the reason the screenshot tests failed. I can't record new linux screenshots based on this branch, because it's in your repo. Would you mind trying to trigger the record snapshots workflow in your fork, throw out the old linux folder and add the linux folder from the resulting screenshots in your fork? If it doesn't work out please let me know, then I can open up a new branch based on yours and record the screenshots. |
🎉 This PR is included in version 3.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Checklist
Please put "X" in the below checkboxes that apply::
I have tested the following:
This PR solves the following problem**.
insert your description.
How to test this PR**.
Implement events where
isCustom
is set to true, and watch your custom event slots resize when you grab the handles.