Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable resize of weekday event slot #222

Merged
merged 5 commits into from
Dec 9, 2023

Conversation

vicdotexe
Copy link
Contributor

Checklist

Please put "X" in the below checkboxes that apply::

  • If committing a bugfix, I have tested it in different browsers (Chrome, Firefox, Safari).
  • If committing a new feature, I have first submitted an issue (Please note: you are free to open PRs for non-issued features, but opening an issue increases your chance of a successful PR). Resizable weekday event slot #221
  • If committing a new feature, I have also written an appropriate test suite for it.

I have tested the following:

  • Qalendar component in month mode.
  • Qalendar component in week mode.
  • Qalendar component in day mode.
  • All of the above modes on emulated mobile view.
  • Dragging and dropping events.
  • Resizing events in day/week modes.
  • Clicking events to open event dialog.

This PR solves the following problem**.

insert your description.

How to test this PR**.

Implement events where isCustom is set to true, and watch your custom event slots resize when you grab the handles.

@tomosterlund tomosterlund self-requested a review December 9, 2023 11:04
@coveralls
Copy link

coveralls commented Dec 9, 2023

Coverage Status

coverage: 97.26% (-0.3%) from 97.577%
when pulling 917ecca on vicdotexe:resizableSlot
into 2515aed on tomosterlund:master.

Copy link
Owner

@tomosterlund tomosterlund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went ahead and removed a wrapping div which looked redundant to me. Feel free to revert though if I missed out on something.

E2E tests are failing though, and I'm not quite sure why yet.

@tomosterlund
Copy link
Owner

tomosterlund commented Dec 9, 2023

It appears to me, that this fixes an old problem I didn't know Qalendar had - namely text overflow from week events. At least sometimes when they're very short. That seems to be the reason the screenshot tests failed.

I can't record new linux screenshots based on this branch, because it's in your repo. Would you mind trying to trigger the record snapshots workflow in your fork, throw out the old linux folder and add the linux folder from the resulting screenshots in your fork?

If it doesn't work out please let me know, then I can open up a new branch based on yours and record the screenshots.

@tomosterlund tomosterlund merged commit 1b16e14 into tomosterlund:master Dec 9, 2023
7 checks passed
@felix-berlin
Copy link
Collaborator

🎉 This PR is included in version 3.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants