fix: event bubbling wrong when clicking on month day event #216
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Please put "X" in the below checkboxes that apply::
I have tested the following:
This PR solves the following problem**.
Prevents the date-was-clicked event from bubbling up when an event is clicked.
I saw that the
.self
modifier was removed 6 months ago on that exact line, maybe there is some reason for this? Otherwise, I tested adding.stop
on the@click
on the event in the month view, which also seems to work.I saw the unit test comment saying there is a problem testing click events with .self? Would writing a unit test testing .stop work?
How to test this PR**.
For example: