Skip to content

Commit

Permalink
daemon: ignore CILIUM_CUSTOM_CNI_CONF when writing cni configuration
Browse files Browse the repository at this point in the history
This file was overly-cautious when mimicking cni-install.sh's behavior.
It turns out we want to be able to disable cni-install.sh but still have
the daemon write the configuration file. This preserves existing
behavior in 1.12.

Thus, we need to remove the bit that bails out if the environment
variable is set.

Fixes: 12b7b11
Signed-off-by: Casey Callendrello <[email protected]>
  • Loading branch information
squeed authored and pchaigno committed Feb 15, 2023
1 parent 2548277 commit 4b803e9
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions daemon/cmd/cni.go
Original file line number Diff line number Diff line change
Expand Up @@ -119,12 +119,6 @@ func (d *Daemon) startCNIConfWriter(opts *option.DaemonConfig, cleaner *daemonCl
return
}

// We used to disable CNI generation with this environment variable
// It's no longer documented, but we need to still support it.
if os.Getenv("CILIUM_CUSTOM_CNI_CONF") == "true" {
return
}

d.controllers.UpdateController(cniControllerName,
controller.ControllerParams{
DoFunc: func(ctx context.Context) error {
Expand Down

0 comments on commit 4b803e9

Please sign in to comment.