Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(parse): Reduce overheasd from "trivia" #764

Merged
merged 5 commits into from
Jul 29, 2024
Merged

perf(parse): Reduce overheasd from "trivia" #764

merged 5 commits into from
Jul 29, 2024

Conversation

epage
Copy link
Member

@epage epage commented Jul 29, 2024

ws_comment_newline was showing up in callgrind when dealing with a lot of features. While this had some impact on benchmarks, it wasn't super big.

@epage epage enabled auto-merge July 29, 2024 15:14
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 29, 2024
View reviewed changes
crates/toml_edit/src/parser/trivia.rs Fixed Show fixed Hide fixed
crates/toml_edit/src/parser/trivia.rs Fixed Show fixed Hide fixed
crates/toml_edit/src/parser/trivia.rs Fixed Show fixed Hide fixed
crates/toml_edit/src/parser/trivia.rs Fixed Show fixed Hide fixed
crates/toml_edit/src/parser/trivia.rs Fixed Show fixed Hide fixed
crates/toml_edit/src/parser/trivia.rs Fixed Show fixed Hide fixed
crates/toml_edit/src/parser/trivia.rs Fixed Show fixed Hide fixed
crates/toml_edit/src/parser/trivia.rs Fixed Show fixed Hide fixed
crates/toml_edit/src/parser/trivia.rs Fixed Show fixed Hide fixed
crates/toml_edit/src/parser/trivia.rs Fixed Show fixed Hide fixed
@coveralls
Copy link

coveralls commented Jul 29, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10147085335

Details

  • 11 of 11 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 67.072%
Totals Coverage Status
Change from base Build 10117749300: 0.07%
Covered Lines: 3693
Relevant Lines: 5506
💛 - Coveralls

@epage epage force-pushed the ws-comment-newline branch from 2ac134f to cc0c6c8 Compare July 29, 2024 15:18
@epage epage merged commit 400a6c5 into toml-rs:main Jul 29, 2024
15 checks passed
@epage epage deleted the ws-comment-newline branch July 29, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@epage @coveralls