Remove failing test #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parser is able to handle datetimes without a trailing Z - it interprets them as valid datetimes in the local timezone. As far as I can tell, this is valid according to the spec: > You may omit the local offset and let the parser or host application decide > that information. A good default is to use the host machine's local offset. We unfortunately can't move this to the `valid` folder, since the current implementation parses in the user's timezone, whatever timezone that is, so whatever value got hardcoded in the `.json` file would fail for every user not using that timezone. Another alternative would be to modify the parser to disallow timestamps that don't have a timezone set, or always default to UTC; I'm OK with anything but I think it would be good to fix the tests.
|
Fixing the tests is good. Once TOML 1.0 hits, I'll take a sweep at these tests and get them updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parser is able to handle datetimes without a trailing Z - it interprets
them as valid datetimes in the local timezone.
As far as I can tell, this is valid according to the spec:
We unfortunately can't move this to the
validfolder, since the currentimplementation parses in the user's timezone, whatever timezone that is, so
whatever value got hardcoded in the
.jsonfile would fail for every user notusing that timezone.
Another alternative would be to modify the parser to disallow timestamps that
don't have a timezone set, or always default to UTC; I'm OK with anything but
I think it would be good to fix the tests.