Skip to content

Commit

Permalink
Configure before freeze
Browse files Browse the repository at this point in the history 
otherwise we can't find a build plan
  • Loading branch information
@tomjaguarpaw
tomjaguarpaw committed Oct 20, 2023
1 parent 5573f03 commit 9112e03
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions .github/workflows/ci.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@ jobs:
ghc-version: ${{ matrix.ghc }}
cabal-version: ${{ matrix.cabal }}

- name: Configure
run: |
cabal configure --enable-tests

This comment has been minimized.

Sign in to view

Copy link
@andreasabel

andreasabel Oct 21, 2023

@tomjaguarpaw Note that the freeze file contains the hackage timestamp, so it is not good to use as cache key: You will never get an exact hit.
I did quite some research and experiments on correct caching, the result is here: https://github.com/haskell-actions/setup#model-cabal-workflow-with-caching

This comment has been minimized.

Sign in to view

Copy link
@tomjaguarpaw

tomjaguarpaw Oct 21, 2023

Author Owner

Useful info, thanks! @0rphee has also done some investigation into this too: kowainik/stan#530

We should try to combine knowledge about this

This comment has been minimized.

Sign in to view

Copy link
@andreasabel

andreasabel Oct 21, 2023

I commented on the PR you linked.
- name: Freeze
run: |
cabal freeze
Expand Down

0 comments on commit 9112e03

Please sign in to comment.