update formidable for Node 6.x compat #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi - there's a newer (but not very new) update to Formidable which contains a fix to support Node 6.x: node-formidable/formidable@f4a3e08 node-formidable/formidable#364 node-formidable/formidable#404
|
@mikeatlas Please let me know if you see any bugs with the new merge. Thanks for the heads up. Sorry for the delay. |
|
Hm, I think we'll need to bump this package's version and push to npm/atmosphere for it to be available? I can do the former but need you (or the owner) to do the latter. Thanks @msj121 ! |
|
@mikeatlas I just did. Sorry for the delay! |
|
Looks good on first blush, thank you @msj121 and @tomitrescak ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi - there's a newer (but not very new) update to Formidable which contains a fix to support Node 6.x:
node-formidable/formidable@f4a3e08
node-formidable/formidable#364
node-formidable/formidable#404
@msj121 Any chance this can get quick attention? I have to fork this somehow, otherwise?