Make change set comment rate limit errors display properly

Fixes openstreetmap#4320
tomhughes · Nov 2, 2023 · ef4c9a3 · ef4c9a3
1 parent b5995c5
commit ef4c9a3
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/app/assets/javascripts/index/changeset.js b/app/assets/javascripts/index/changeset.js
@@ -47,7 +47,7 @@ OSM.Changeset = function (map) {
         OSM.loadSidebarContent(window.location.pathname, page.load);
       },
       error: function (xhr, xhr_status, http_status) {
-        $(form).find("#comment-error").text(http_status);
+        $(form).find("#comment-error").text(xhr.responseText);
         $(form).find("#comment-error").prop("hidden", false);
         $(form).find("input[type=submit]").prop("disabled", false);
       }

diff --git a/app/views/browse/changeset.html.erb b/app/views/browse/changeset.html.erb
@@ -78,7 +78,7 @@
         <div class="mb-3">
           <textarea class="form-control" name="text" cols="40" rows="5"></textarea>
         </div>
-        <div id="comment-error" class="alert-danger p-2 mb-3" hidden>
+        <div id="comment-error" class="alert alert-danger p-2 mb-3" hidden>
         </div>
         <div>
           <input type="submit" name="comment" value="<%= t("javascripts.changesets.show.comment") %>" data-changeset-id="<%= @changeset.id %>" data-method="POST" data-url="<%= changeset_comment_url(@changeset) %>" disabled="1" class="btn btn-sm btn-primary" />

diff --git a/lib/osm.rb b/lib/osm.rb
@@ -355,6 +355,10 @@ def status
 
   # Raised when a rate limit is exceeded
   class APIRateLimitExceeded < APIError
+    def initialize
+      super "Rate limit exceeded"
+    end
+
     def status
       :too_many_requests
     end