Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle EINTR in Stream.poll() #76

Closed
wants to merge 1 commit into from

Conversation

vmalloc
Copy link
Contributor

@vmalloc vmalloc commented May 7, 2012

It seems like Stream.poll() did not retry select() in cases of signal interruptions

@tomerfiliba
Copy link
Collaborator

okay, i added a call to signal.siginterrupt in the forked child, so this should solve the issue.

i agree it's a good practice to handle the possible EINTR, but because it's in the "critical path", i'm a bit more cautious about it. besides, it's a bit complicated to cover all cases of EINTR, as almost any syscall can return with this errno. if the problem persists, i'll incorporate the patch, but if not, i think its best to leave it this way. thanks for the research!

@tomerfiliba
Copy link
Collaborator

i'm closing the issue now, let me now if the problem persists

@vmalloc
Copy link
Contributor Author

vmalloc commented May 11, 2012

Awesome. Thanks!

@vmalloc vmalloc mentioned this pull request Jun 4, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants