Add types.MappingProxyType to _builtin_types #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Essentially I need it so that "isinstance(netref, types.MappingProxyType)" will return the expected result (True) if "netref" is a netref to MappingProxyType.
|
I wouldn't worry too much about adding tests. I think those unit tests would come naturally with a fix to #355 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Essentially I need it so that "isinstance(netref, types.MappingProxyType)"
will return the expected result (True) if "netref" is a netref to MappingProxyType.
After this change, it works as expected.
I can add a test (e.g of
isinstance) but I didn't find any suitable spot for that. (I think that we don't test all types in_builtin_types, anyway. We might want to?)