Skip to content

Commit

Permalink
Added note/todo for recv_event which might simplify the protocol whil…
Browse files Browse the repository at this point in the history
…e fixing perilous corner cases like a thread never calling notify_all #492
  • Loading branch information
comrumino committed Jul 2, 2022
1 parent b2d8ef0 commit aea6059
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion rpyc/core/protocol.py
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ def __init__(self, root, channel, config={}):
self._seqcounter = itertools.count()
self._recvlock = RLock()
self._sendlock = Lock()
self._recv_event = Condition()
self._recv_event = Condition() # TODO: current use may suggest we could simply timeout and catch an acquire
self._request_callbacks = {}
self._local_objects = RefCountingColl()
self._last_traceback = None
Expand Down

0 comments on commit aea6059

Please sign in to comment.