Fairly extensive update #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inal EE1.sugar Updated outdated syntax in Comments.xml and link in ReadMe
…noperable cruft from original EE1.sugar Added itemizers to colorize EE2 tags within attribute strings
…atch the default Espresso theme
…scaping backslashes
…to the exceptions list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Tom,
A user was having trouble with the EE2.sugar and wrote in to us, and since I had some free time today I went through it and made some updates to remove old cruft that wasn't doing any good anymore, get the TextActions working again, and remove conflicts between it and the HTML itemizers and syntax coloring.
Do note that I completely rewrote the placeholder theme. Placeholder themes should generally match the Espresso default theme; if you want to include coloring for a third-party Sugar in a custom theme, then that theme should override the placeholder and define its own colors. This is now possible (since the placeholder before had two IDs, which isn't the way it should work), and a lot simpler because I streamlined the selectors the theme is using. However, it is a fairly big change to the Sugar itself, and might make things look "broken" until you update whatever custom theme(s) you are using in conjunction with the Sugar.
Feel free to keep my changes or not as you see fit! I tried to keep things separated out into separate commits to make them easy to pull in or leave out.
Ian