Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tell people to first test the dummy app, before going down this path #106

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stefanpenner
Copy link
Collaborator

cc @kellyselden / @rwjblue can you provide some use-cases where this add-on is required, and testing the existing dummy app does not work?

@simonihmig
Copy link
Collaborator

@stefanpenner did you notice the issue I created for documenting/collecting use cases? See #104

@trentmwillis
Copy link
Collaborator

IMO, the only really useful area this addon serves is testing build code which is not appropriately tested through normal unit tests. I view the use of this addon as an "acceptance" testing of sorts for add-ons that need to verify that when dropped into a real application the build output is correct.

This is what we use it for in ember-engines. Thus, if you need to test build behavior for your addon when used as a nested addon or used multiple times in an application or so on, then this helps facilitate that.

@stefanpenner
Copy link
Collaborator Author

stefanpenner commented May 26, 2017

IMO, the only really useful area this addon serves is testing build code which is not appropriately tested through normal unit tests.

It sounds like we should provide helpers (by default) that test the dummy app instead?

@kellyselden
Copy link
Collaborator

@stefanpenner I just discovered another use case.

  • Your addon is failing in the wild because you accidentally installed a required dependency to dev deps instead of deps. There is no way (that I know of) to prevent this via normal testing because both the addon and dummy app share the same package.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants