v0.8.6 Broke custom controls

[adgoncal]

Hi,

I just noticed that 0.8.6 breaks custom controls.

In 'src/services/leafletControlHelpers.js', function isValidControlType is checking if the control is in controlTypes object, but 'custom' is not.

In 'src/directives/controls.js', it calls isValidControlType to check if the control is valid, but returns early on custom controls.

[MarkAPhillips]

I have this problem also and had to revert back to 0.8.5

[nmccready]

@elesdoar @tombatossals ?

@adgoncal @MarkAPhillips please checkout this PR as it changed. #831

My guess is we should have moved to 0.9.X

[sibbl]

There are more troubles than just isValidControlType("custom") not returning true as one could use an array of controls as value of the controls key custom in 0.8.5. This doesn't work anymore as well in 0.8.6. I guess this needs some more rewriting.

[MarkAPhillips]

If there are issues in this, can it be reverted and then pushed when fully tested and documented into 0.9.0 rather than 0.8.6. I need to review the changes as in the current state it completely breaks my application. @tombatossals can you advise how this is to be addressed so I can decide how I should proceed. I do not mind reworking my control code but before I start if you intend to fix the issues in the next week will hold off until then - thanks.

[paambaati]

Stuck on the same boat; I'm working on a new app and I suppose I picked the exact wrong time to add a custom control - none of the examples work, and the documentation doesn't apply anymore. For now, I'm just hacking into the main distributable as a stop-gap, but it would be great if documentation at least shows 1 example with adding a new custom control.

[Diones]

Exactly, the same here. Version 0.8.5 working fine.

[nmccready]

@tombatossals should we go to 0.9.X and is controls working in a different manner now? #899

[nmccready]

Also is there new documentation for this?

[tombatossals]

Hi, sorry I haven't used custom controls before, and there was no test nor example showing how they must work. I have solved the issue in the last commit, and added a new example of how to load a custom example.

@nmccready the controls works the same way as before, they were reworked to be able to extend and add new controls to the library easily, but maybe is a good moment to go to 0.9.x.

No new documentation needed, because they work as before (now at least).

[nmccready]

Cool ty

[nmccready]

Cutting a new release soon closing.