Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compareTo method of Violation is broken and filters too many unique warnings #98

Closed
uhafner opened this issue Aug 27, 2020 · 1 comment
Closed

compareTo method of Violation is broken and filters too many unique warnings #98

uhafner opened this issue Aug 27, 2020 · 1 comment

Comments

@uhafner
Copy link
Contributor

uhafner commented Aug 27, 2020

See 487cfbb#r41822784.
tomasbjerre added a commit that referenced this issue Aug 27, 2020
@tomasbjerre
Avoid removing violations that are not duplicates #98
0b81ef8
@tomasbjerre
Copy link
Owner

Thanks for reporting!!

Fixed in 1.123

uhafner added a commit to jenkinsci/analysis-model that referenced this issue Aug 28, 2020
@uhafner
Add test that exposes the false duplications in the PitAdapter.
0501861 
tomasbjerre/violations-lib#98.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomasbjerre @uhafner