Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkstyle: don't fail if rule attribute is not present #23

Closed
hectorj opened this issue Sep 1, 2017 · 3 comments
Closed

Checkstyle: don't fail if rule attribute is not present #23

hectorj opened this issue Sep 1, 2017 · 3 comments

Comments

@hectorj
Copy link

hectorj commented Sep 1, 2017

Hi!

I'm having an issue with parsing checkstyle files coming from phpstan using this lib, as their errors don't have the source attribute, which makes this lib log an error and ignore the violation.

Would it be possible to consider the source as optional?

I am also opening an issue on phpstan to add the source attribute, as I am not sure which fix would be better.

@hectorj
Copy link
Author

hectorj commented Sep 1, 2017

phpstan issue for reference : phpstan/phpstan#481

@tomasbjerre
Copy link
Owner

Yes no problem. I'm releasing it now, will release the plugins later today.

@hectorj
Copy link
Author

hectorj commented Sep 1, 2017

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants