Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix test failures in node v4-v12 #398

Merged
merged 1 commit into from
Apr 7, 2022

Conversation

joeyparrish
Copy link
Contributor

These failures were introduced by PR #392

Rather than abort the request, set up a listener to silence any errors
thrown late, as happens on macOS in certain node versions.

Closes #397

These failures were introduced by PR tomas#392

Rather than abort the request, set up a listener to silence any errors
thrown late, as happens on macOS in certain node versions.

Closes tomas#397
@tomas tomas merged commit b5cf883 into tomas:master Apr 7, 2022
@joeyparrish joeyparrish deleted the fix-node-v12 branch April 20, 2022 15:54
joeyparrish added a commit to joeyparrish/less.js that referenced this pull request Apr 20, 2022
The issue was traced upstream to needle, and resolved in:
 - tomas/needle#392
 - tomas/needle#394
 - tomas/needle#396
 - tomas/needle#398

Closes less#3693
iChenLei pushed a commit to less/less.js that referenced this pull request Apr 22, 2022
The issue was traced upstream to needle, and resolved in:
 - tomas/needle#392
 - tomas/needle#394
 - tomas/needle#396
 - tomas/needle#398

Closes #3693
lumburr pushed a commit to lumburr/less.js that referenced this pull request Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failures on node v4-v12
2 participants