add lookup param for request #357

machao · 2021-06-15T03:05:53Z

http://nodejs.cn/api/http.html#http_http_request_url_options_callback

usage:

needle({
  url,
  lookup: (hostname, options, callback) => {
     if(hostname.endsWith('.localhost')) {
        setImmediate(() => {
           callback(null, '127.0.0.1', 4);
        });
        return
     }
     dns.lookup(hostname, options, callback);
  }
})

http://nodejs.cn/api/http.html#http_http_request_url_options_callback

tomas · 2021-06-15T13:24:05Z

lib/needle.js

@@ -16,7 +16,8 @@ var fs          = require('fs'),
    auth        = require('./auth'),
    cookies     = require('./cookies'),
    parsers     = require('./parsers'),
-    decoder     = require('./decoder');
+    decoder     = require('./decoder'),
+    dns         = require('dns');


Is this necessary?

It doesn't seem to be necessary

@machao could you update the PR?

lyswhut · 2021-06-17T09:50:15Z

I need this option and hope to merge soon

lyswhut · 2021-06-27T13:00:56Z

@machao Don't close it directly, please update this PR to merge it?
Thank

machao · 2021-06-27T13:03:19Z

i'm sorry about useless code in this pr, and i open new one. #360

add lookup param for request

ec1c648

http://nodejs.cn/api/http.html#http_http_request_url_options_callback

tomas reviewed Jun 15, 2021

View reviewed changes

machao closed this Jun 27, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add lookup param for request #357

add lookup param for request #357

machao commented Jun 15, 2021

tomas Jun 15, 2021

lyswhut Jun 17, 2021

tomas Jun 17, 2021

lyswhut commented Jun 17, 2021

lyswhut commented Jun 27, 2021 •

edited

Loading

machao commented Jun 27, 2021

add lookup param for request #357

add lookup param for request #357

Conversation

machao commented Jun 15, 2021

tomas Jun 15, 2021

Choose a reason for hiding this comment

lyswhut Jun 17, 2021

Choose a reason for hiding this comment

tomas Jun 17, 2021

Choose a reason for hiding this comment

lyswhut commented Jun 17, 2021

lyswhut commented Jun 27, 2021 • edited Loading

machao commented Jun 27, 2021

lyswhut commented Jun 27, 2021 •

edited

Loading