Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mangle uniq #388

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add mangle uniq #388

wants to merge 3 commits into from

Conversation

kittizz
Copy link
Contributor

@kittizz kittizz commented Dec 2, 2024

Proposed change

Add support for using mangle rule 'comment' field as part of the unique identifier for switches in Home Assistant.

Motivation

i managing multiple mangle rules for VPN traffic routing, the existing unique identifier keys may not be sufficient to distinguish between similar rules. Adding the 'comment' field allows for better identification and management of mangle rules through Home Assistant, especially when dealing with multiple rules that share common properties.

I previously skipped rules with empty comments, but you brought them back. I think having these rules makes the system more organized and easier to manage, especially when wanting to control rules through Home Assistant

Type of change

  • Bugfix
  • New feature
  • Code quality improvements to existing code or addition of tests
  • Documentation

Additional information

Checklist

  • The code change is tested and works locally.
  • The code has been formatted using Black.
  • Tests have been added to verify that the new code works.
  • Documentation added/updated if required.

@kittizz
Copy link
Contributor Author

kittizz commented Dec 2, 2024

working
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant