Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File dialog spring clean #387

Open
tom-seddon opened this issue Nov 11, 2024 · 4 comments
Open

File dialog spring clean #387

tom-seddon opened this issue Nov 11, 2024 · 4 comments
Labels
UI/UX something user-facing, contributing to a suboptimal experience

Comments

@tom-seddon
Copy link
Owner

Reported here: https://www.stardot.org.uk/forums/viewtopic.php?p=438465#p438465
@tom-seddon tom-seddon added linux anything Linux-related UI/UX something user-facing, contributing to a suboptimal experience labels Nov 11, 2024
@tom-seddon
Copy link
Owner Author

Should probably be specifying GTK_FILE_CHOOSER_ACTION_SAVE here:

b2/src/b2/native_ui_gtk.cpp

Line 193 in a8b4f2a

GTK_FILE_CHOOSER_ACTION_OPEN);

@tom-seddon
Copy link
Owner Author

Suggested patch here: https://www.stardot.org.uk/forums/viewtopic.php?p=439030#p439030

@tom-seddon
Copy link
Owner Author

I think this actually needs a separate create file dialog type - to be continued.

The suggested patch looks good enough to be getting on with.

tom-seddon added a commit that referenced this issue Nov 17, 2024
@tom-seddon
Fix Gtk file chooser type when saving.
29434a2 
See #387. This is not a fix, but it'll do for now.
@tom-seddon tom-seddon changed the title Wrong Gtk file dialog type for creating a new disk image? File dialog spring clean Nov 20, 2024
@tom-seddon tom-seddon removed the linux anything Linux-related label Nov 20, 2024
@tom-seddon
Copy link
Owner Author

tom-seddon commented Nov 20, 2024 •
edited
Loading

The Windows default extension stuff has never worked right either... and when creating a new file, it should supply a suggested file name...

Patch has been applied, so the worst of it is fixed. But I think this does need a certain amount of looking at, across all platforms.

Poked about on Windows, and eyed the GTK docs. macOS... unknown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
UI/UX something user-facing, contributing to a suboptimal experience
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tom-seddon