Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layline damping factor set to 1 causes failure #52

Open
rgleason opened this issue Mar 25, 2022 · 2 comments
Open

layline damping factor set to 1 causes failure #52

rgleason opened this issue Mar 25, 2022 · 2 comments

Comments

@rgleason
Copy link
Contributor

When Preferences > Parameters > Layline Damping factor is set to 1 it causes Opencpn to fail, also if show polar is on it does not show, and if show laylines is on the laylines are incorrect and only show one brown layline.

Obviously there is some calculation that does not work if layline damping is 1.
Therefore I am going to change the range in just the text to be 0.025 -0.99 rather than 0.025-1

but there should be further corrections made with bounds checking and fix the calculation!

Note: It does not appear that "layline width damping factor" has this problem.

@rgleason
Copy link
Contributor Author

All I have done is change the range allowed in the message!

Tactics_pi.cpp

Line 3593:     //---Layline damping factor -----------------
Line 3594:     wxStaticText* itemStaticText18 = new wxStaticText(itemPanelNotebook03, wxID_ANY, _("Layline damping factor [0.025-1]:  "),

Changed to

Tactics_pi.cpp

Line 3593:     //---Layline damping factor -----------------
Line 3594:     wxStaticText* itemStaticText18 = new wxStaticText(itemPanelNotebook03, wxID_ANY, _("Layline damping factor [0.025-0.99]:  "),

@rgleason
Copy link
Contributor Author

rgleason@8f943d1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant