Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated README.md. By default You need to require additional namespace - tolitius.reporter.html #18

Merged
merged 1 commit into from
Feb 19, 2018

Conversation

voytech
Copy link
Contributor

@voytech voytech commented Feb 19, 2018

@tolitius
And yet - there was an issue when generating reports (I think it is only on windows machine). I was clearing temp directory every time before adding items into it. While writing reports - it expected warning interim file to be present (in fact it doesn't use this file at this time - but it must be related to specific filesystem management operation on windows - as it expected file with issues to be present while iterating tmpdir before writing final html report file).

@tolitius
I do not know how You would like to incorporate this fix? is it required to up the version? or You can make it in-place with current version.

…ce in build.boot in order to be able to run checkers.
@tolitius
Copy link
Owner

versions are not sacred, if the world's Clojure standard allow it (like it is allowed in Golang) I would only use commit hash for versioning, since 1.2.3 means nothing, and ce3a92c tells you exactly what/where and when it is.

I'll bump the version.

@tolitius tolitius merged commit af6351f into tolitius:master Feb 19, 2018
tolitius added a commit that referenced this pull request Feb 19, 2018
tolitius added a commit that referenced this pull request Feb 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants