Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: es2017 compatibility #3371

Merged
merged 3 commits into from
Sep 20, 2024
Merged

fix: es2017 compatibility #3371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
008f1fc
fix: es2017 compatibility
stepan662 Sep 20, 2024
47cbc3f
chore: upgrade upload-artifact
stepan662 Sep 20, 2024
2e40c53
chore: fix e2e tests
stepan662 Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ jobs:
env:
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}

- uses: actions/upload-artifact@v2
- uses: actions/upload-artifact@v4
if: always()
with:
name: cypress
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/report-intermittent-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ jobs:
- name: Cypress
run: pnpm run e2e run --headed ${{matrix.app}} --stdout prod,dev

- uses: actions/upload-artifact@v2
- uses: actions/upload-artifact@v4
if: failure()
with:
name: cypress
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ jobs:
- name: Run e2e tests
run: pnpm run e2e run --headed ${{matrix.app}} --stdout prod,dev --skip-build

- uses: actions/upload-artifact@v2
- uses: actions/upload-artifact@v4
if: failure()
with:
name: cypress
Expand Down
3 changes: 3 additions & 0 deletions packages/svelte/vite.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@ import { sveltekit } from '@sveltejs/kit/vite';

/** @type {import('vite').UserConfig} */
const config = {
build: {
target: 'es2017',
},
plugins: [sveltekit()],
};

Expand Down
2 changes: 1 addition & 1 deletion packages/web/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"compilerOptions": {
"target": "ES2020",
"target": "es2017",
"useDefineForClassFields": true,
"lib": ["ES2020", "DOM", "DOM.Iterable"],
"module": "ESNext",
Expand Down
1 change: 1 addition & 0 deletions packages/web/vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ export const createConfig = ({ entry, rollupOptions }: Props) =>
defineConfig({
clearScreen: false,
build: {
target: 'es2017',
emptyOutDir: false,
minify: false,
sourcemap: true,
Expand Down
2 changes: 1 addition & 1 deletion scripts/e2eRunner/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import path from 'path';
export const config: Config = {
dockerComposeServices: {
app: {
waitForOutput: 'Tomcat started on port(s): 8080 (http)',
waitForOutput: 'Tomcat started on port 8080',
},
},
tests: {
Expand Down