Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imrpovements 3 #9

Open
15 tasks done
JanCizmar opened this issue Oct 29, 2024 · 0 comments
Open
15 tasks done

Imrpovements 3 #9

JanCizmar opened this issue Oct 29, 2024 · 0 comments

Comments

@JanCizmar
Copy link
Contributor

JanCizmar commented Oct 29, 2024

  • cli is not good name for command. Name it tolgee-migrator
  • Don't use .env for passing the openApi credentials, instad pass it using commandline arguments. We don't want to make users to create the .env in the project directory, since they're running it as external command
  • Name te .tolgee direcotry .tolgee-migrator
  • When running the script, check whether the .tolgee-migrator is in gitignore and if not, add it there, so it doesn't create changes. Then commit this, so user starts with clean git again.
  • It wrongly starts producing files in the .tolgee directory even if it fails on missing credentials
  • It doesn't work on the test project
    • On error it just writes empty file
    • It keeps the code wrapped with javascript ...
    • When it reaches timeout, it should wait and then retry, not fail. OpenAi returns the number of seconds to wait
  • It logs too much. The output has to be delightful
    • Use log levels
    • Default - Long only important & error messages, show progress bar visualizing processed files / total files
    • verbose - also log which file is currently handled
    • debug, log all - full prompts and responses from ChatGpt from each file
    • You can use winston for this: https://github.com/winstonjs/winston
MatejMicikas pushed a commit that referenced this issue Nov 6, 2024
JanCizmar added a commit that referenced this issue Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant