Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build error when alloc feature is disabled #11

Merged
merged 2 commits into from
May 11, 2021
Merged

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented May 11, 2021

Fixes build error by the way mentioned in #10 (comment).

print only variant name when alloc feature is disabled? (like the following)

#[cfg(feature = "alloc")]
let name = format!("{}::{}", self.name, variant.name());
#[cfg(not(feature = "alloc"))]
let name = variant.name();

@taiki-e taiki-e requested a review from carllerche May 11, 2021 19:14
run: rustup update stable
- name: Install cargo-hack
run: cargo install cargo-hack
- run: cargo hack build --workspace --feature-powerset --no-dev-deps
Copy link
Member Author

@taiki-e taiki-e May 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, our MSRV is 1.51 (because we use min const generics), so we can use resolver = "2" that the more preferable than --no-dev-deps (that edit Cargo.toml).

UPDATE: done in 013dca6

@taiki-e taiki-e mentioned this pull request May 11, 2021
@carllerche carllerche merged commit eba3f71 into master May 11, 2021
@taiki-e taiki-e deleted the taiki-e/no-alloc branch May 12, 2021 01:27
@taiki-e taiki-e mentioned this pull request Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants