opentelemetry: support attributes for metrics #2354
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As detailed by @nmoutschen in #2337, attributes are currently not supported when recording metrics. Attributes are needed to add dimensions to metric data without enumerating all possible combinations as different metrics.
The linked issue contains more details regarding the motivation for this change.
Solution
This implements the solution suggested by @nmoutschen, where a special prefix of
attribute.
is used to define attributes to record with the metric. For example, the below records two counts for the metricmy_counter_metric
each with separate values formy_attribute
.Attributes may be
i64
,f64
,str
orbool
as supported byopentelemetry::Value
.Fixes #2337