Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert even more intra-doc links #1077

Merged
merged 4 commits into from
Nov 2, 2020

Conversation

jyn514
Copy link
Contributor

@jyn514 jyn514 commented Nov 2, 2020

Motivation

#940

Solution

This changes the docs.rs links, many of which were broken (or would have been broken on the next release). It also converts some links I missed the first time (maybe they were added after I opened the PR?).

@jyn514 jyn514 requested review from hawkw, jtescher, yaahc and a team as code owners November 2, 2020 18:51
@jyn514
Copy link
Contributor Author

jyn514 commented Nov 2, 2020

As a side note - have you considered running cargo deadlinks or something similar in CI? That would have caught a lot of these broken links, I think.

(disclaimer: I maintain cargo-deadlinks and want more people to use it :P)

@hawkw
Copy link
Member

hawkw commented Nov 2, 2020

As a side note - have you considered running cargo deadlinks or something similar in CI? That would have caught a lot of these broken links, I think.

This is the first I've heard of cargo deadlinks, but I think running it sounds like a great idea! Do you have the time to set up a CI job that runs it?

@jyn514
Copy link
Contributor Author

jyn514 commented Nov 2, 2020

Absolutely! I'll make a follow-up PR with that.

Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@hawkw hawkw merged commit a0e1daa into tokio-rs:master Nov 2, 2020
@jyn514 jyn514 deleted the you-thought-you-escaped branch November 2, 2020 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants