io: remove redundant check #6966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That seems really fragile. I would say that keeping the unpacking is better. |
Darksonn
reviewed
Nov 13, 2024
Co-authored-by: Alice Ryhl <[email protected]>
kodiakhq bot
pushed a commit
to pdylanross/fatigue
that referenced
this pull request
Dec 4, 2024
Bumps tokio from 1.41.1 to 1.42.0.
Release notes
Sourced from tokio's releases.
Tokio v1.42.0
1.42.0 (Dec 3rd, 2024)
Added
io: add AsyncFd::{try_io, try_io_mut} (#6967)
Fixed
io: avoid ptr->ref->ptr roundtrip in RegistrationSet (#6929)
runtime: do not defer yield_now inside block_in_place (#6999)
Changes
io: simplify io readiness logic (#6966)
Documented
net: fix docs for tokio::net::unix::{pid_t, gid_t, uid_t} (#6791)
time: fix a typo in Instant docs (#6982)
#6791: tokio-rs/tokio#6791
#6929: tokio-rs/tokio#6929
#6966: tokio-rs/tokio#6966
#6967: tokio-rs/tokio#6967
#6982: tokio-rs/tokio#6982
#6999: tokio-rs/tokio#6999
Commits
bb9d570 chore: prepare Tokio v1.42.0 (#7005)
af9c683 tests: fix typo in build test instructions (#7004)
4bc5a1a ci: allow Unicode-3.0 license for unicode-ident (#7006)
f8948ea runtime: do not defer yield_now inside block_in_place (#6999)
bce9780 time: use array::from_fn instead of manually creating array (#7000)
38151f3 readme: unlist 1.32.x as LTS release (#6997)
5dda72d ci: pin valgrind to rustc 1.82 (#6998)
c07257f io: simplify io readiness logic (#6966)
d08578f time: fix a typo in Instant docs (#6982)
4047d79 miri: add annotations for tests with miri ignore (#6981)
Additional commits viewable in compare view
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes a redundant checks:
1. No need to unpackreadiness, Since readiness is already positioned at the least significant portion, AndReady::from_usizeperforms internal masking2. Remove
if !existing.will_wake { .. }, Sincewaker.clone_fromalready performs this optimization internally.3. Updated
fn set_readiness(), to skip calling the closuref(..)when possible.