Update CI config #5893
Merged
Update CI config #5893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
taiki-e
commented
Jul 28, 2023
•
taiki-e
commented
- Remove duplicate target from cross-test
- Remove needless --test-threads=1 as RUST_TEST_THREADS=1 already specifies it
- Remove --cfg tokio_no_ipv6 as setup-cross-toolchain-action supports it
- Automatically cancel all outdated workflows on PR (currently this is only set for ci.yml)
- Remove --cfg tokio_no_atomic_u64 as tests/builds with --target target-specs/i686-unknown-linux-gnu.json handles these cases
- Remove duplicate target from cross-test - Remove needless --test-threads=1 (already specified by RUST_TEST_THREADS=1) - Remove --cfg tokio_no_ipv6 as setup-cross-toolchain-action supports it
Currently, this is only set for ci.yml.
NobodyXu
suggested changes
Jul 28, 2023
Comment on lines
466
to
+467
| RUST_TEST_THREADS: 1 | ||
| RUSTFLAGS: --cfg tokio_unstable -Dwarnings --cfg tokio_no_ipv6 --cfg tokio_no_tuning_tests ${{ matrix.rustflags }} | ||
| RUSTFLAGS: --cfg tokio_unstable -Dwarnings --cfg tokio_no_tuning_tests ${{ matrix.rustflags }} |
There was a problem hiding this comment.
I just realized these RUST* flags should be set before Swatinem/rust-cache@v2:
- name: Set RUST env
run: |
echo RUST_TEST_THREADS=1 >> "$GITHUB_ENV"
echo 'RUSTFLAGS=--cfg tokio_unstable -Dwarnings --cfg tokio_no_tuning_tests ${{ matrix.rustflags }}' >> "$GITHUB_ENV"
There was a problem hiding this comment.
Considering how Swatinem/rust-cache works, it may be best for some workflows that meet certain conditions, but since we don't change rustflags often and sometimes set different rustflags for each step, I think it is also fine as-is.
tests/builds with --target target-specs/i686-unknown-linux-gnu.json handles these cases.
Darksonn
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.