Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unused tokio_* cfgs #5890

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Conversation

NobodyXu
Copy link
Contributor

Motivation

#5887 bumped MSRV to 1.63, now these cfgs are useless.

Solution

Remove unused cfgs:

  • tokio_no_const_thread_local
  • tokio_no_target_has_atomic
  • tokio_no_as_fd

@Darksonn Darksonn added A-tokio Area: The main tokio crate M-fs Module: tokio/fs M-io Module: tokio/io M-net Module: tokio/net M-process Module: tokio/process M-task Module: tokio/task M-macros Module: macros in the main Tokio crate labels Jul 28, 2023
tokio/src/fs/file.rs Outdated Show resolved Hide resolved
 - tokio_no_const_thread_local
 - tokio_no_target_has_atomic
 - tokio_no_as_fd

Signed-off-by: Jiahao XU <[email protected]>
@NobodyXu NobodyXu force-pushed the remove-unused-cfgs branch from 0db351b to 32d8d57 Compare July 28, 2023 10:24
@NobodyXu NobodyXu requested a review from Darksonn July 28, 2023 10:27
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@Darksonn Darksonn merged commit fb08591 into tokio-rs:master Jul 28, 2023
@NobodyXu NobodyXu deleted the remove-unused-cfgs branch July 28, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate M-fs Module: tokio/fs M-io Module: tokio/io M-macros Module: macros in the main Tokio crate M-net Module: tokio/net M-process Module: tokio/process M-task Module: tokio/task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants