deps!: bump socket2
(to 0.5.3
) and MSRV (to 1.63
)
#5877
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Due to MSRV restrictions, the
tokio
crate depends on an old version of thesocket2
crate that depends on thewinapi
crate. This is unfortunate because nowadays, we should prefer the officially maintainedwindows-sys
crate for Windows API bindings.Note that this problem is not only an issue of updating dependencies to the latest version. By keeping the old version of
socket2
around, we are forcing consumers of thetokio
crate to download and compile two redundant crates in the dependency tree:winapi
andwindows-sys
. With the latter being officially supported, it is about time we prunewinapi
from the dependency tree.Solution
This PR bumps
socket2
to version0.5
, which is the final piece in the dependency tree that still previously relied onwinapi
. See the changelog for more details. All references in the documentation and manifest files have been updated accordingly.Note that this has already been attempted in #5603. However, due to MSRV constraints, the author promptly closed the PR. A few months later, it should now be safe to bump the MSRV to
1.63
, which also happens to be the MSRV forsocket2
. Since1.63
was released eleven months ago as of writing, we are well beyond the six-month eligibility requirement of the MSRV policy. 🎉