signal: expose CtrlC stream on windows (closes #3178) #3186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darksonn
added
A-tokio
* Make tokio::signal::windows::ctrl_c() public. * Stop referring to private tokio::signal::windows::Event in module documentation.
niklasf
force-pushed
the
windows-ctrl-c
branch
from
02dcab8 to
399b8c4
Compare
niklasf
added a commit
to lichess-org/fishnet
that referenced
this pull request
Nov 27, 2020
niklasf
force-pushed
the
windows-ctrl-c
branch
from
805f916 to
f3212c4
Compare
|
Thanks for the fast turnaround! |
This was referenced Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When continuously handling Ctrl+C using
tokio::signal::ctrl_c()in a loop, the handler gets registered and deregistered on each iteration. It is useful to instead have an infinite stream of events. This is already possible with signals on Unix andtokio::signal::windows::ctrl_break()on Windows, buttokio::signal::windows::ctrl_c()is currently private.Solution
ctrl_c()public, analogous to the already publicctrl_break().tokio::signal::windows::Eventin the module documentation. ExposingEventwould be an alternative solution here, but the chosen approach seems more consistent with the existing API.