uds: illumos can build using existing Solaris support #2563
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, let me begin by saying I understand that the v0.1 series of tokio is deprecated. Unfortunately it's still seeing somewhat wide usage in the ecosystem, including in RLS in the official Rust toolchain:
I'd like to make this small change to allow us to build RLS on illumos, now that support for our host triple is in the compiler (see rust-lang/rust#71145 and rust-lang/rust#55553) and we're on the path to being in the official CI/CD system (see rust-lang/rust#71272 and rust-lang/compiler-team#279). The existing support in
tokio-uds
here for Solaris systems is sufficient also for illumos, we just need to fix the conditional compilation directives and get a v0.2.7 oftokio-uds
out the door.I've run the test suite for
tokio-uds
on a current illumos system and it appears to work.Thanks!