Use load instead of get_mut

tokio-rs · Jan 27, 2024 · f93c704 · f93c704
1 parent be6b4bc
commit f93c704
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/tokio/src/sync/broadcast.rs b/tokio/src/sync/broadcast.rs
@@ -1430,9 +1430,10 @@ impl<'a, T> Drop for Recv<'a, T> {
             let mut tail = self.receiver.shared.tail.lock();
 
             // Safety: tail lock is held.
+            // `Relaxed` order suffices because we hold the tail lock.
             let queued = self
                 .waiter
-                .with_mut(|ptr| unsafe { *(*ptr).queued.get_mut() });
+                .with_mut(|ptr| unsafe { (*ptr).queued.load(Relaxed) });
 
             if queued {
                 // Remove the node