tcp: deprecate TcpStream::try_clone() (#824)

tokio-rs · Jan 5, 2019 · a687922 · a687922
1 parent df299ce
commit a687922
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/tokio-tcp/src/stream.rs b/tokio-tcp/src/stream.rs
@@ -781,9 +781,14 @@ impl TcpStream {
     /// # Ok(())
     /// # }
     /// ```
+    #[deprecated(since = "0.1.14", note = "use `split()` instead")]
+    #[doc(hidden)]
     pub fn try_clone(&self) -> io::Result<TcpStream> {
-        let io = self.io.get_ref().try_clone()?;
-        Ok(TcpStream::new(io))
+        // Rationale for deprecation:
+        // - https://github.com/tokio-rs/tokio/pull/824
+        // - https://github.com/tokio-rs/tokio/issues/774#issuecomment-451059317
+        let msg = "`TcpStream::split()` is deprecated because it doesn't work as intended";
+        Err(io::Error::new(io::ErrorKind::Other, msg))
     }
 }