Skip to content

Commit

Permalink
Remove expectation of duration value from sleep test
Browse files Browse the repository at this point in the history
The value isn't stable, and never made sense in the first place (sleep
for 7 milliseconds and get a `duration.op` of 8?!?!).
  • Loading branch information
hds committed Dec 3, 2024
1 parent a98c989 commit 28d26eb
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion tokio/tests/tracing_time.rs
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,10 @@ async fn test_sleep_creates_span() {
.with_target("runtime::resource::state_update")
.with_fields(
expect::field("duration")
.with_value(&(7_u64 + 1))
// FIXME(hds): This value isn't stable and doesn't seem to make sense. We're not
// going to test on it until the resource instrumentation has been
// refactored and we know that we're getting a stable value here.
//.with_value(&(7_u64 + 1))
.and(expect::field("duration.op").with_value(&"override")),
);

Expand Down

0 comments on commit 28d26eb

Please sign in to comment.