Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix case on type attribute in prost-build documentation #668

Merged
merged 2 commits into from
Jun 20, 2022
Merged

fix case on type attribute in prost-build documentation #668

merged 2 commits into from
Jun 20, 2022

Conversation

zkrzyzanowski
Copy link
Contributor

@zkrzyzanowski zkrzyzanowski commented Jun 19, 2022

This fixes a small error in the prost-build documentation where an example for a serde attribute used kabob-case instead of snake_case. Correct syntax confirmed in their docs here

Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The CI failures are related to a MSRV change in our deps so once #669 gets merged you can rebase and we can re-run CI and merge.

@LucioFranco LucioFranco merged commit b1c57cd into tokio-rs:master Jun 20, 2022
@zkrzyzanowski zkrzyzanowski deleted the prost-build-type-attribute-documentation branch June 20, 2022 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants