-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include Message Descriptor information #336
Closed
Closed
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
2003f95
Include Message Proto information
fdeantoni 4d56eac
Various formatting fixes.
fdeantoni d1f42ab
Renamed MessageProto to MessageDescriptor.
fdeantoni 9a8445d
Merge branch 'master' into meta
fdeantoni a27f565
Merge branch 'master' of https://github.com/danburkert/prost into meta
fdeantoni 510cd4d
Merge branch 'meta' of https://github.com/fdeantoni/prost into meta
fdeantoni fc2bccc
Merge branch 'master' into meta
fdeantoni 06d6371
Updates due to merge with upstream.
fdeantoni 7bcbed8
Fixed formatting errors.
fdeantoni f8cb1b2
Updated well-known-types test.
fdeantoni d42f84d
Add static lifetime for generic_derive test.
fdeantoni 87c3f3a
Add generics to MessageDescriptor.
fdeantoni 086dcb1
Merge branch 'master' into meta
fdeantoni 5d4bd66
Merge branch 'master' into meta
fdeantoni 4989326
Merge branch 'master' into meta.
fdeantoni 319e38f
Changed visibility of prost_attrs to pub(crate).
fdeantoni File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the above methods should be associated functions instead. Someone will be able to use
Foo::type_url()
instead of constructingFoo
and then calling the method.For example this is how pack/unpack to
Any
will be implemented with associated functions: