Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prost-build doc link broken on docs.rs #960

Closed
paxsonsa opened this issue Dec 14, 2023 · 2 comments
Closed

prost-build doc link broken on docs.rs #960

paxsonsa opened this issue Dec 14, 2023 · 2 comments

Comments

@paxsonsa
Copy link

On the main page for Prost, the link to prost-build is linking to the readme path in the repo. This works on Crates and GitHub but breaks on doc.rs

Happy to submit a fix but wondering if we prefer for it to link to doc.rs or continue to link to GitHub?
@paxsonsa
Copy link
Author

This link:
https://github.com/tokio-rs/prost/blob/master/README.md?plain=1#L39

paxsonsa added a commit to paxsonsa/prost that referenced this issue Dec 15, 2023
@paxsonsa
update the prost-build documentation link to point to the doc.rs docu…
2034426 
…mentation; This is to fix the broken link on doc.rs referenced in: tokio-rs#960
@paxsonsa paxsonsa mentioned this issue Dec 15, 2023
Closed
@caspermeijn
Copy link
Collaborator

Fixed in #967

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@caspermeijn @paxsonsa